[
https://issues.apache.org/jira/browse/HIVE-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2711:
------------------------------
Attachment: HIVE-2711.D2571.1.patch
omalley requested code review of "HIVE-2711 [jira] Make the header of RCFile
unique".
Reviewers: JIRA
HIVE-2711
Make the header of RCFile unique wrt SequenceFile
The RCFile implementation was copied from Hadoop's SequenceFile and copied
the 'magic' string in the header. This means that you can't use the header to
distinguish between RCFiles and SequenceFiles.
I'd propose that we create a new header for RCFiles (RCF?) to replace the
current SEQ. To maintain compatibility, we'll need to continue to accept the
current 'SEQ\06' and just make new files contain the new header.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2571
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/data/rc-file-v0.rc
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5835/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Make the header of RCFile unique
> --------------------------------
>
> Key: HIVE-2711
> URL: https://issues.apache.org/jira/browse/HIVE-2711
> Project: Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2711.D2115.1.patch, HIVE-2711.D2571.1.patch
>
>
> The RCFile implementation was copied from Hadoop's SequenceFile and copied
> the 'magic' string in the header. This means that you can't use the header to
> distinguish between RCFiles and SequenceFiles.
> I'd propose that we create a new header for RCFiles (RCF?) to replace the
> current SEQ. To maintain compatibility, we'll need to continue to accept the
> current 'SEQ\06' and just make new files contain the new header.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
