[
https://issues.apache.org/jira/browse/HIVE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245064#comment-13245064
]
Phabricator commented on HIVE-2848:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2848 [jira] Add
validation to HiveConf ConfVars".
INLINE COMMENTS
ql/src/test/queries/clientnegative/set_hiveconf_validation0.q:1 Please add a
comment explaining what you're trying to test.
ql/src/test/queries/clientnegative/set_hiveconf_validation1.q:2 Ditto.
ql/src/test/results/clientnegative/set_hiveconf_validation0.q.out:1 The error
message should reference the property that we were trying to set. "'SET
hive.foo.bar=abc' FAILED because hive.foo.bar expects an INT value."
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:678 Checkstyle
violation.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:671 Probably a
checkstyle violation. Please check.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:600 Java Enum names
use CamelCase by default. I think our Checkstyle configuration is setup to flag
anything else a style violation. Please check.
REVISION DETAIL
https://reviews.facebook.net/D2313
BRANCH
DPAL-970
> Add validation to HiveConf ConfVars
> -----------------------------------
>
> Key: HIVE-2848
> URL: https://issues.apache.org/jira/browse/HIVE-2848
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Kevin Wilfong
> Assignee: Navis
> Attachments: HIVE-2848.D2313.1.patch, HIVE-2848.D2313.2.patch,
> HIVE-2848.D2313.3.patch, HIVE-2848.D2313.4.patch
>
>
> It would be good if we could add some validation to ConfVars in the HiveConf
> when they are set.
> At least if a variable is supposed to be boolean, numeric, or
> strict/nonstrict, it shouldn't be too difficult to check for these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
