[ 
https://issues.apache.org/jira/browse/HIVE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246712#comment-13246712
 ] 

Phabricator commented on HIVE-2530:
-----------------------------------

kevinwilfong has commented on the revision "HIVE-2530 [jira] Implement SHOW 
TBLPROPERTIES".

  Thanks, Lei.  I just noticed a couple more small things.

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java:2532-2534 Thanks for 
making it one try catch block.  One other thing I noticed is we're doing this 
twice, but it looks like doing it at the beginning of the try should be 
sufficient.
  ql/src/java/org/apache/hadoop/hive/ql/plan/ShowTblPropertiesDesc.java:38 
Could you update this comment, it's not show tables.
  ql/src/java/org/apache/hadoop/hive/ql/plan/ShowTblPropertiesDesc.java:42 here 
too.
  ql/src/java/org/apache/hadoop/hive/ql/plan/ShowTblPropertiesDesc.java:62-65 
The descriptions of these variables looks wrong.

REVISION DETAIL
  https://reviews.facebook.net/D2589

                
> Implement SHOW TBLPROPERTIES
> ----------------------------
>
>                 Key: HIVE-2530
>                 URL: https://issues.apache.org/jira/browse/HIVE-2530
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Adam Kramer
>            Assignee: Lei Zhao
>            Priority: Minor
>         Attachments: HIVE-2530.D2589.1.patch, HIVE-2530.D2589.2.patch
>
>
> Since table properties can be defined arbitrarily, they should be easy for a 
> user to query from the command-line.
> SHOW TBLPROPERTIES tblname;
> ...would show all of them, one per row, key \t value
> SHOW TBLPROPERTIES tblname ("FOOBAR");
> ...would just show the value for the FOOBAR tblproperty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to