[ 
https://issues.apache.org/jira/browse/HIVE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253019#comment-13253019
 ] 

Ashutosh Chauhan commented on HIVE-2936:
----------------------------------------

I see. Agree on both points. Another point is this increases number on calls on 
nn, it will be good to reduce that if possible. How about following:
{code}
  boolean success = fs.mkdirs(f);
      if(success) {
        if (this.inheritPerms && fs.exists(f.getParent())) {
          try {
            fs.setPermission(f, 
fs.getFileStatus(f.getParent()).getPermission());
          } catch (IOException ioe) {
            LOG.equals("Failed to set permissions");
            success = false;
          }

        }
      } else {
        return fs.getFileStatus(f).isDir();
      }
      return success;
{code}

How about this. The case of returning false if you fail to set Permissions is 
not clear. I return false, what you think ?
                
> Warehouse table subdirectories should inherit the group permissions of the 
> warehouse parent directory
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2936
>                 URL: https://issues.apache.org/jira/browse/HIVE-2936
>             Project: Hive
>          Issue Type: New Feature
>          Components: Metastore
>            Reporter: Rohini Palaniswamy
>            Assignee: Rohini Palaniswamy
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2504-1.patch, HIVE-2504.patch, HIVE-2504.patch
>
>
> When the Hive Metastore creates a subdirectory in the Hive warehouse for
> a new table it does so with the default HDFS permissions derived from 
> dfs.umask or dfs.umaskmode. There should be a option to inherit the 
> permissions of the parent directory (default warehouse or custom database 
> directory) so that the table directories have the same permissions as the 
> database directories. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to