[ 
https://issues.apache.org/jira/browse/HIVE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2930:
------------------------------

    Attachment: HIVE-2930.D2835.1.patch

omalley requested code review of "HIVE-2930 [jira] Add license to the Hive 
files".
Reviewers: JIRA

  <<Enter Revision Title>>

  Fixing rat warnings

  We need to clean up the RAT report to 0. Apache projects aren't supposed to 
release until they have shown that all of their files have proper headers.

  Note that although most of the files are just missing headers, some of them 
explicitly say copyright by facebook and released under the Thrift (not Apache) 
license. I'll generate a list of them, but I'd really appreciate it if someone 
from facebook could in verify that they intend to license them to Apache.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2835

AFFECTED FILES
  .checkstyle
  build.properties
  build.xml
  common/src/java/conf/hive-log4j.properties
  conf/configuration.xsl
  conf/hive-env.sh.template
  data/conf/hive-log4j.properties
  data/scripts/cat.py
  data/scripts/cat_error.py
  data/scripts/dumpdata_script.py
  data/scripts/error_script
  data/scripts/input20_script
  docs/velocity.properties
  eclipse-templates/.classpath
  eclipse-templates/.classpath._hbase
  eclipse-templates/.externalToolBuilders/Hive_Ant_Builder.launch
  eclipse-templates/.project
  eclipse-templates/.settings/org.eclipse.jdt.core.prefs
  eclipse-templates/.settings/org.eclipse.jdt.ui.prefs
  eclipse-templates/HiveCLI.launchtemplate
  eclipse-templates/TestCliDriver.launchtemplate
  eclipse-templates/TestEmbeddedHiveMetaStore.launchtemplate
  eclipse-templates/TestHBaseCliDriver.launchtemplate
  eclipse-templates/TestHive.launchtemplate
  eclipse-templates/TestHiveMetaStoreChecker.launchtemplate
  eclipse-templates/TestJdbc.launchtemplate
  eclipse-templates/TestMTQueries.launchtemplate
  eclipse-templates/TestRemoteHiveMetaStore.launchtemplate
  eclipse-templates/TestTruncate.launchtemplate
  hbase-handler/src/test/templates/TestHBaseCliDriver.vm
  metastore/if/hive_metastore.thrift
  metastore/scripts/hive.metastore_ctrl
  metastore/scripts/hive.metastore_daemon
  metastore/scripts/upgrade/001-HIVE-2795.update_view_partitions.py
  metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
  metastore/src/model/package.jdo
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyPreListener.java
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteUGIHiveMetaStoreIpAddress.java
  ql/if/queryplan.thrift
  ql/src/java/conf/hive-exec-log4j.properties
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/mapredplan.jr
  ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java
  ql/src/test/org/apache/hadoop/hive/ql/exec/sample_plan.xml
  ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled
  ql/src/test/scripts/testgrep
  ql/src/test/templates/TestCliDriver.vm
  ql/src/test/templates/TestNegativeCliDriver.vm
  ql/src/test/templates/TestParse.vm
  ql/src/test/templates/TestParseNegative.vm
  serde/if/serde.thrift
  serde/if/test/complex.thrift
  serde/if/test/complexpb.proto
  serde/if/test/testthrift.thrift
  
serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java
  serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/thrift_grammar.jjt
  service/lib/php/ext/thrift_protocol/config.m4
  service/lib/php/ext/thrift_protocol/tags/1.0.0/config.m4
  service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.cpp
  service/lib/php/ext/thrift_protocol/tags/1.0.0/php_thrift_protocol.h
  service/lib/py/fb303/__init__.py
  service/lib/py/thrift/protocol/fastbinary.c
  service/lib/py/thrift/reflection/__init__.py
  service/lib/py/thrift/reflection/limited/__init__.py
  service/src/test/php/test_service.php
  testutils/compute_stats
  testutils/dump_schema
  testutils/run_tests

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6429/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Add license to the Hive files
> -----------------------------
>
>                 Key: HIVE-2930
>                 URL: https://issues.apache.org/jira/browse/HIVE-2930
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>         Attachments: HIVE-2930.D2835.1.patch
>
>
> We need to clean up the RAT report to 0. Apache projects aren't supposed to 
> release until they have shown that all of their files have proper headers.
> Note that although most of the files are just missing headers, some of them 
> explicitly say copyright by facebook and released under the Thrift (not 
> Apache) license. I'll generate a list of them, but I'd really appreciate it 
> if someone from facebook could in verify that they intend to license them to 
> Apache.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to