[ 
https://issues.apache.org/jira/browse/HIVE-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-2959:
------------------------------

    Attachment: HIVE-2959.D2841.1.patch

kevinwilfong requested code review of "HIVE-2959 [jira] 
TestRemoteHiveMetaStoreIpAddress always uses the same port".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2959

  TestRemoteHiveMetaStoreIpAddress now uses the standard way of finding a free 
port using Java's ServerSocket class.

  TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if 
another process happens to be using that port, the tests cannot succeed.

  There seems to be a standard way of finding a free port using Java's 
ServerSocket class, this should be used instead.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2841

AFFECTED FILES
  
metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStoreIpAddress.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6435/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> TestRemoteHiveMetaStoreIpAddress always uses the same port
> ----------------------------------------------------------
>
>                 Key: HIVE-2959
>                 URL: https://issues.apache.org/jira/browse/HIVE-2959
>             Project: Hive
>          Issue Type: Test
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2959.D2841.1.patch
>
>
> TestRemoteHiveMetaStoreIpAddress always uses the same port, meaning that if 
> another process happens to be using that port, the tests cannot succeed.
> There seems to be a standard way of finding a free port using Java's 
> ServerSocket class, this should be used instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to