[
https://issues.apache.org/jira/browse/HIVE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2961:
------------------------------
Attachment: HIVE-2961.D2877.1.patch
kevinwilfong requested code review of "HIVE-2961 [jira] Remove need for storage
descriptors for view partitions".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2961
Removed the need for storage descriptors for view partitions and the script
to add them.
Storage descriptors were introduced for view partitions as part of HIVE-2795.
This was to allow view partitions to have the concept of a region as well as
to fix a NPE that resulted from calling describe formatted on them.
Since regions are no longer necessary for view partitions and the NPE can be
fixed by not displaying storage information for view partitions (or displaying
the view's storage information if this is preferred, although, since a view
partition is purely metadata, this does not seem necessary), these are no
longer needed.
This also means the Python script added which retroactively adds storage
descriptors to existing view partitions can be removed.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2877
AFFECTED FILES
metastore/scripts/upgrade/001-HIVE-2795.update_view_partitions.py
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
ql/src/test/results/clientpositive/describe_formatted_view_partitioned_json.q.out
ql/src/test/results/clientpositive/describe_formatted_view_partitioned.q.out
ql/src/test/queries/clientpositive/describe_formatted_view_partitioned_json.q
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6525/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Remove need for storage descriptors for view partitions
> -------------------------------------------------------
>
> Key: HIVE-2961
> URL: https://issues.apache.org/jira/browse/HIVE-2961
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2961.D2877.1.patch
>
>
> Storage descriptors were introduced for view partitions as part of HIVE-2795.
> This was to allow view partitions to have the concept of a region as well as
> to fix a NPE that resulted from calling describe formatted on them.
> Since regions are no longer necessary for view partitions and the NPE can be
> fixed by not displaying storage information for view partitions (or
> displaying the view's storage information if this is preferred, although,
> since a view partition is purely metadata, this does not seem necessary),
> these are no longer needed.
> This also means the Python script added which retroactively adds storage
> descriptors to existing view partitions can be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
