[ https://issues.apache.org/jira/browse/HIVE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269095#comment-13269095 ]
Phabricator commented on HIVE-1719: ----------------------------------- cwsteinbach has requested changes to the revision "HIVE-1719 [jira] Move RegexSerDe out of hive-contrib and over to hive-serde". Looks good, but we need to copy the regex serde testcases from contrib over to ql. I also noticed that the negative testcase isn't documented, and doesn't seem to exercise any of the error conditions in RegexSerDe.initialize(). Can you please add some additional test coverage for these cases? Thanks. REVISION DETAIL https://reviews.facebook.net/D3051 BRANCH HIVE-1719 > Move RegexSerDe out of hive-contrib and over to hive-serde > ---------------------------------------------------------- > > Key: HIVE-1719 > URL: https://issues.apache.org/jira/browse/HIVE-1719 > Project: Hive > Issue Type: Task > Components: Serializers/Deserializers > Reporter: Carl Steinbach > Assignee: Shreepadma Venugopalan > Attachments: HIVE-1719.D3051.1.patch, HIVE-1719.D3051.2.patch > > > RegexSerDe is as much a part of the standard Hive distribution as the other > SerDes > currently in hive-serde. I think we should move it over to the hive-serde > module so that > users don't have to go to the added effort of manually registering the > contrib jar before > using it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira