[ 
https://issues.apache.org/jira/browse/HIVE-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291812#comment-13291812
 ] 

ransom.hezhiqiang commented on HIVE-3101:
-----------------------------------------

the default hook is HBaseStorageHandler, it will be cover these codes when 
create hbase table. 
so i think we already have some unit test about hbase table in hive. 
it doesn't need to create unit test.
if we need more test case, i will create it. 
                
> dropTable will all ways excute hook.rollbackDropTable whether drop table 
> success or faild.
> ------------------------------------------------------------------------------------------
>
>                 Key: HIVE-3101
>                 URL: https://issues.apache.org/jira/browse/HIVE-3101
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: ransom.hezhiqiang
>            Assignee: ransom.hezhiqiang
>         Attachments: HIVE-3101.1.patch
>
>
> see  the codes:
>  boolean success = false;
>     try {
>       client.drop_table(dbname, name, deleteData);
>       if (hook != null) {
>         hook.commitDropTable(tbl, deleteData);
>       }
>     } catch (NoSuchObjectException e) {
>       if (!ignoreUknownTab) {
>         throw e;
>       }
>     } finally {
>       if (!success && (hook != null)) {
>         hook.rollbackDropTable(tbl);
>       }
>     }
> success  will always false, whether  the drop was success or faild.
> so it's a bug. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to