[ 
https://issues.apache.org/jira/browse/HIVE-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397391#comment-13397391
 ] 

Prasad Mujumdar commented on HIVE-3121:
---------------------------------------

Looks fine to me overall. A few minor comments/suggestions
- getSchemaTerm() should return "schema"
- getCatalogTerm() should return ""
- I think it would be helpful to rename the getTableCatalog() in JdbcColumn and 
JdbcTable classes

                
> JDBC driver's getCatalogs() method returns schema/db information
> ----------------------------------------------------------------
>
>                 Key: HIVE-3121
>                 URL: https://issues.apache.org/jira/browse/HIVE-3121
>             Project: Hive
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 0.9.0
>            Reporter: Carl Steinbach
>         Attachments: hive-3121.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to