-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5507/
-----------------------------------------------------------

Review request for hive, Carl Steinbach and Carl Steinbach.


Description
-------

Support passing configuration and substitution variable as part of JDBC 
connection string. 
The new format of the URL is 
jdbc:hive://<host>:<port>/dbName?hive_conf_list#hive_var_list   , where the 
optional conf and var lists are semicolon separated <key>=<val> pairs. As 
before, if the host/port is not specified, it the driver runs an embedded hive.
examples -
jdbc:hive://ubuntu:11000/db2?hive.cli.conf.printheader=true;hive.exec.mode.local.auto.inputbytes.max=9999#stab=salesTable;icol=customerID
jdbc:hive://?hive.cli.conf.printheader=true;hive.exec.mode.local.auto.inputbytes.max=9999#stab=salesTable;icol=customerID

The patch include new routines to parse the URL. The conf values are added to 
HiveConf when hive is running in embedded mode otherwise they are configured 
using 'set' statement. The variable substitution is only used in case of 
embedded mode.


This addresses bug HIVE-3166.
    https://issues.apache.org/jira/browse/HIVE-3166


Diffs
-----

  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 6618243 
  jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java c61425f 
  jdbc/src/java/org/apache/hadoop/hive/jdbc/Utils.java 24d5882 
  jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java f6a904f 

Diff: https://reviews.apache.org/r/5507/diff/


Testing
-------

Ran JDBC tests.
Added new test case for the extended URL format.


Thanks,

Prasad Mujumdar

Reply via email to