[
https://issues.apache.org/jira/browse/HIVE-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424999#comment-13424999
]
Edward Capriolo commented on HIVE-3317:
---------------------------------------
Sorry to be a pain but can we please update the comment.
// ignore error reading file, if we can't read it then it isn't a windows
script
I have a hard time understanding the intentions of the code when I read double
negatives.
> Fix “TestDosToUnix” unit tests on Windows by closing the leaking file handle
> in DosToUnix.java.
> -----------------------------------------------------------------------------------------------
>
> Key: HIVE-3317
> URL: https://issues.apache.org/jira/browse/HIVE-3317
> Project: Hive
> Issue Type: Sub-task
> Components: Import/Export, Windows
> Affects Versions: 0.10.0, 0.9.1
> Environment: Windows
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows
> Fix For: 0.10.0, 0.9.1
>
> Attachments: HIVE-3317.1.patch.txt
>
>
> Windows can’t delete the files if there are any open file handles on it so it
> is required to close them properly after completing the validation in
> DosToUnix utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
