-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6962/
-----------------------------------------------------------
(Updated Sept. 10, 2012, 11:24 p.m.)
Review request for hive, Carl Steinbach and Carl Steinbach.
Changes
-------
The patch has been updated to take in -tablePropKey <table-prop-key> from the
user. This option is valid only with the -updateLocation option. When
-tablePropKey option is specified metatool looks for records in SD_PARAMS and
updates those records whose key match the the table-prop-key specified by the
user and whose value matches the <old-loc> specified with -updateLocation
option. The new metatool option looks as below,
metatool -updateLocation <new-loc> <old-loc> -tablePropKey <table-prop-key>
serdeParamKey <serde-param-key>
Both -tablePropKey and -serdePropKey are optional.
Description
-------
This patch adds an additional option to Hive Metatool that allows Metatool to
take in a serdeParamKey from the user. Avro Serde's schema URL key used to be
called schema.url in the past whereas its called avro.schema.url now. The
purpose of the patch is to make Metatool more generic than what it is today so
that its in a position to handle variations such as the one described above.
The new option looks as below,
-serdeParamKey <serde_param_key>=<value>
Note that the new Option -serdeParamKey is valid only with the -updateLocation
option. When the user attempts to use the serdeParamKey option with other
options, an error is raised and the usage is printed.
If the user doesn't pass -serdeParamKey as part of the -updateLocation option,
Hive Metatool searches for records with both "avro.schema.url" and "schema.url"
keys and updates them.
This addresses bug HIVE-3343.
https://issues.apache.org/jira/browse/HIVE-3343
Diffs (updated)
-----
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 251d4ba
metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java
a76594a
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java
5790ae9
Diff: https://reviews.apache.org/r/6962/diff/
Testing
-------
HiveMetaTool has been tested to verify that it handles both avro.schema.url and
schema.url correctly. Existing test case in TestHiveMetaTool.java has been
modified to use AvroSerDe instead of LazySimpleSerDe.
Thanks,
Shreepadma Venugopalan
