[
https://issues.apache.org/jira/browse/HIVE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453814#comment-13453814
]
Zhenxiao Luo commented on HIVE-3339:
------------------------------------
@Namit:
Thanks a lot for the comments.
I just updated the patch, and review request at:
https://reviews.facebook.net/D5343
> Change the rules in SemanticAnalyzer to use Operator.getName() instead of
> hardcoded names
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-3339
> URL: https://issues.apache.org/jira/browse/HIVE-3339
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Zhenxiao Luo
> Priority: Minor
> Attachments: HIVE-3339.1.patch.txt, HIVE-3339.2.patch.txt
>
>
> This should be done for code cleanup.
> Instead of the rule being:
> SEL%
> It should say SelectOperator.getName()%
> It would make the rules more readable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
