[
https://issues.apache.org/jira/browse/HIVE-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463533#comment-13463533
]
Phabricator commented on HIVE-3315:
-----------------------------------
njain has commented on the revision "HIVE-3315 [jira] Propagate filers on inner
join condition transitively".
INLINE COMMENTS
ql/src/test/results/clientpositive/auto_join29.q.out:3160 There is a bug here
-
the new result looks correct if I manually think about the query results.
But, the results should be the same irrespective of this patch.
Anyway, outside the scope of this patch.
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java:38 the
comment is confusing - nothing gets replaced
ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java:77
nit: can you have ( at the next line - it is confusing
ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java:66
confusing: can you pass newFilters in the context passed to the rule dispatcher
same for filterPropagates etc.
ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java:183
missing full_outer_join
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java:44 The size
of sources, targets can be diff.
if targets.size() < index
return null
ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java:93
Wont it be simpler to add the filter in JoinTransitive instead of returning
this array, and
then inserting it here ?
REVISION DETAIL
https://reviews.facebook.net/D4497
To: JIRA, navis
Cc: njain
> Propagates filters which are on the join condition transitively
> ----------------------------------------------------------------
>
> Key: HIVE-3315
> URL: https://issues.apache.org/jira/browse/HIVE-3315
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.10.0
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-3315.1.patch.txt, HIVE-3315.2.patch.txt,
> HIVE-3315.3.patch.txt, HIVE-3315.D4497.5.patch, HIVE-3315.D4497.6.patch
>
>
> explain select src1.key from src src1 join src src2 on src1.key=src2.key and
> src1.key < 100;
> In this case, filter on join condition src1.key < 100 can be propagated
> transitively to src2 by src2.key < 100.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
