----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7634/#review12510 -----------------------------------------------------------
Looks good. Needs one minor edit to the property description. conf/hive-default.xml.template <https://reviews.apache.org/r/7634/#comment26641> s/defaults is /defaults to/ - Carl Steinbach On Oct. 17, 2012, 8:58 a.m., Esteban Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7634/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2012, 8:58 a.m.) > > > Review request for hive. > > > Description > ------- > > Simple implementation of TCP KeepAlive and socket timeout for the HiveServer > in order to avoid half open connections or connection drops during long > running queries that use HiveServer. Two new settings have been added in > order to control this functionality: hive.server.read.socket.timeout and > hive.server.tcp.keepalive the proposal is to have hive.server.tcp.keepalive > set by default to true. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f86d6a7 > conf/hive-default.xml.template 4a59fb6 > service/src/java/org/apache/hadoop/hive/service/HiveServer.java 2b2f681 > > Diff: https://reviews.apache.org/r/7634/diff/ > > > Testing > ------- > > > Thanks, > > Esteban Gutierrez > >
