[ 
https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Steinbach updated HIVE-2715:
---------------------------------

    Status: Open  (was: Patch Available)

@Ashutosh: After applying the patch I deleted the contents of 
*/src/gen/thrift/*, and then tried running the thriftif target again, and 
noticed that the following files are not replaced:

{noformat}
 D 
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java
 D metastore/src/gen/thrift/gen-php/ThriftHiveMetastore.php
 D metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
 D metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php
 D metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_types.php
 D metastore/src/gen/thrift/gen-php/hive_metastore_constants.php
 D metastore/src/gen/thrift/gen-php/hive_metastore_types.php
 D ql/src/gen/thrift/gen-php/queryplan/queryplan_types.php
 D serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java
 D 
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
 D 
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MiniStruct.java
 D 
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MyEnum.java
 D serde/src/gen/thrift/gen-php/serde/serde_constants.php
 D serde/src/gen/thrift/gen-php/serde/serde_types.php
 D service/src/gen/thrift/gen-php/hive_service/ThriftHive.php
 D service/src/gen/thrift/gen-php/hive_service/hive_service_types.php
{noformat}


The missing Constants.java files appear to be caused by THRIFT-1090.

I also think it would be a good idea to modify the thriftif Ant target to 
automatically clean the old generated artifacts before running the code 
generator. The HiveServer2 patch actually includes this modification, so maybe 
it would be worthwhile copying it from there and including it in this patch.
                
> Upgrade Thrift dependency to 0.9.0
> ----------------------------------
>
>                 Key: HIVE-2715
>                 URL: https://issues.apache.org/jira/browse/HIVE-2715
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.9.0, 0.8.0
>            Reporter: Mithun Radhakrishnan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-2715.patch
>
>
> I work on HCatalog (0.2). Recently, we ran into HCat_server running out of 
> memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, 
> recently fixed).
> HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. 
> (The bug also exists on 0.7.0.)
> May I please enquire if Hive can't depend on a more current version of 
> thrift? (Does it break the metastore?) I'm afraid I'm not privy to the 
> reasoning behind Hive's dependency on a slightly dated thrift-lib. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to