[
https://issues.apache.org/jira/browse/HIVE-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488507#comment-13488507
]
Phabricator commented on HIVE-1362:
-----------------------------------
njain has commented on the revision "HIVE-1362 [jira] column level statistics".
I wont go over cosmetic changes -- newline at the end of the file etc.
Please fix those.
One higher level question: (SA == SemanticAnalyzer)
1. StatsSemanticAnalyzer - looks like a wrong name - can you rename it to
AnalyzeColumnStatsSema.. given that we already have a StatsTask etc. for
something totally different.
2. The code looks more complicated - I mean, calling SemanticAnalyzer from
StatsSemanticAnalyzer, specially for non-rewritten queries. Won't it be simpler
to:
a. Either StatsSA should extend SA
b. Move the logic for analyze (old) in StatsSA
INLINE COMMENTS
ql/src/test/queries/clientnegative/columnstats_partlvl.q:13 Looks fishy -
wont the test error out at the first error.
Subsequent errors would just be ignored
Can you add more negative tests - wrong column name.
REVISION DETAIL
https://reviews.facebook.net/D6339
To: JIRA, njain, cwsteinbach
> column level statistics
> -----------------------
>
> Key: HIVE-1362
> URL: https://issues.apache.org/jira/browse/HIVE-1362
> Project: Hive
> Issue Type: Sub-task
> Components: Statistics
> Reporter: Ning Zhang
> Assignee: Shreepadma Venugopalan
> Attachments: HIVE-1362.1.patch.txt, HIVE-1362.2.patch.txt,
> HIVE-1362.3.patch.txt, HIVE-1362.4.patch.txt, HIVE-1362.5.patch.txt,
> HIVE-1362.6.patch.txt, HIVE-1362.7.patch.txt, HIVE-1362.8.patch.txt,
> HIVE-1362.D6339.1.patch, HIVE-1362-gen_thrift.1.patch.txt,
> HIVE-1362-gen_thrift.2.patch.txt, HIVE-1362-gen_thrift.3.patch.txt,
> HIVE-1362-gen_thrift.4.patch.txt, HIVE-1362-gen_thrift.5.patch.txt,
> HIVE-1362-gen_thrift.6.patch.txt, HIVE-1362_gen-thrift.7.patch.txt,
> HIVE-1362_gen-thrift.8.patch.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
