[
https://issues.apache.org/jira/browse/HIVE-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497830#comment-13497830
]
Phabricator commented on HIVE-3531:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-3531 [jira] Simple lock
manager for dedicated hive server".
INLINE COMMENTS
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDedicatedLockManager.java:1
Missing ASF license header.
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DedicatedLockManager.java:25
Please consider changing the name to EmbeddedLockManager.
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DedicatedLockManager.java:27
I'm not sure that creating a separate class for the InMemoryLockManager code
makes sense. Please consider removing InMemoryLockManager and moving that code
here.
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/InMemoryLockManager.java:145
Please log this exception.
REVISION DETAIL
https://reviews.facebook.net/D5871
BRANCH
DPAL-1906
To: JIRA, cwsteinbach, navis
> Simple lock manager for dedicated hive server
> ---------------------------------------------
>
> Key: HIVE-3531
> URL: https://issues.apache.org/jira/browse/HIVE-3531
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Server Infrastructure
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-3531.D5871.1.patch
>
>
> In many cases, we uses hive server as a sole proxy for executing all the
> queries. For that, current default lock manager based on zookeeper seemed a
> little heavy. Simple in-memory lock manager could be enough.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
