[ 
https://issues.apache.org/jira/browse/HIVE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502530#comment-13502530
 ] 

Ashutosh Chauhan commented on HIVE-2983:
----------------------------------------

Patch looks good. Couple of questions:
* I don't see a reason to publish ant-tasks jar, we can take that out of the 
list.
* I don't get why you have special handled exec?
                
> Hive ant targets for publishing maven artifacts can be simplified
> -----------------------------------------------------------------
>
>                 Key: HIVE-2983
>                 URL: https://issues.apache.org/jira/browse/HIVE-2983
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Travis Crawford
>            Assignee: Travis Crawford
>            Priority: Minor
>         Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2983.D2961.1.patch
>
>
> Hive has a few ant tasks related to publishing maven artifacts. As not all 
> sub projects publish artifacts the {{iterate}} macro that simplifies other 
> tasks cannot be used in this context.
> Hive already uses the {{for}} task from ant-contrib, which works great here. 
> {{build.xml}} can be simplified by using the for task when preparing maven 
> artifacts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to