[
https://issues.apache.org/jira/browse/HIVE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504178#comment-13504178
]
Ashutosh Chauhan commented on HIVE-3726:
----------------------------------------
Couple of comments:
* HiveServer uses TmpOutputFile, which it deletes (now via session.close()),
but never closes the input stream which it opens on that file in readResults()
and setupSessionIO() methods. This will result in leaking of file-descriptors.
HiveServer2 has copy-pasted this code, so this leak occurs there too.
* I am not sure about changes in SessionState per task. With your patch, each
task will close the {{SessionState}} when it finishes. A query may have
multiple tasks, so this implies every task will create SessionState when it
begin executing, which seems counter-intuitive, since there should be one
sessionstate object across all tasks of the query which was the case earlier
too, isnt it?
> History file closed in finalize method
> --------------------------------------
>
> Key: HIVE-3726
> URL: https://issues.apache.org/jira/browse/HIVE-3726
> Project: Hive
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: HIVE-3726.2-r1411423.patch, HIVE-3736.1-r1411423.patch
>
>
> TestCliNegative fails intermittently because it's up to the garbage collector
> to close History files. This is only a problem if you deal with a lot of
> SessionState objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
