[
https://issues.apache.org/jira/browse/HIVE-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505283#comment-13505283
]
Phabricator commented on HIVE-3384:
-----------------------------------
ashutoshc has requested changes to the revision "[jira] [HIVE-3384] HIVE JDBC
module won't compile under JDK1.7 as new methods added in JDBC specification".
Patch looks good. Couple of minor comments.
INLINE COMMENTS
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java:49 Unneeded
import.
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java:29 Duplicate
import
metastore/build.xml:106 Why UseSplitVerifier is required? Unless there is a
strong reason for this I will recommend to get rid of this, since this flag is
specific to Oracle JVM, we should avoid vendor specific flag for better
portability.
REVISION DETAIL
https://reviews.facebook.net/D6873
BRANCH
trunk
To: cdrome, weidongbian, JIRA, ashutoshc, mbautin
> HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC
> specification
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3384
> URL: https://issues.apache.org/jira/browse/HIVE-3384
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Reporter: Weidong Bian
> Priority: Minor
> Attachments: D6873-0.9.1.patch, D6873.1.patch, HIVE-3384.2.patch,
> HIVE-3384.patch, HIVE-JDK7-JDBC.patch
>
>
> jdbc module couldn't be compiled with jdk7 as it adds some abstract method in
> the JDBC specification
> some error info:
> error: HiveCallableStatement is not abstract and does not override abstract
> method <T>getObject(String,Class<T>) in CallableStatement
> .
> .
> .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
