[
https://issues.apache.org/jira/browse/HIVE-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511082#comment-13511082
]
Phabricator commented on HIVE-2477:
-----------------------------------
njain has commented on the revision "HIVE-2477 [jira] Use name of original
expression for name of CAST output".
minor comments
INLINE COMMENTS
ql/src/test/queries/clientpositive/alias_casted_column.q:1 you forgot to add
the output file for this
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1185 do you
want to add a indirection ?
something like:
isOpPreserveInputName() -- which can call isOpCast (isOpCast can be private).
and the caller (SemanticAnalyzer can call isOpPreserveName). If in future
there
is another function with this requirement, it would be easy.
REVISION DETAIL
https://reviews.facebook.net/D7161
To: JIRA, navis
Cc: njain
> Use name of original expression for name of CAST output
> -------------------------------------------------------
>
> Key: HIVE-2477
> URL: https://issues.apache.org/jira/browse/HIVE-2477
> Project: Hive
> Issue Type: Improvement
> Reporter: Adam Kramer
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2477.1.patch.txt, HIVE-2477.D7161.1.patch
>
>
> CAST(foo AS INT)
> should, by default, consider itself a column named foo if
> unspecified/unaliased.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira