[ 
https://issues.apache.org/jira/browse/HIVE-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533441#comment-13533441
 ] 

Phabricator commented on HIVE-446:
----------------------------------

njain has commented on the revision "HIVE-446 [jira] Implement TRUNCATE".

INLINE COMMENTS
  ql/src/test/queries/clientpositive/truncate_table.q:3 Isn't readnputs and 
writeInputs populated correctly for truncate ?

  If yes, shouldn't these commands fail for src/srcpart etc.
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:748 I 
remember you added a new function getTable() to do all error checking etc.
  Cant you re-use that ?
  ql/src/test/queries/clientpositive/truncate_table.q:8 What is the behavior 
for a non-partitioned table, when partition spec. is not specified ?
  Either throw an error, or truncate all partitions ?

  Support specifying partial partition specifications:

  truncate table srcpart partition (ds='2008-04-08' hr);
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:759 It 
should be possible to specify partial partn specifications
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:754 add 
negative test for this.
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java:3895 inputs/outputs 
not populated

REVISION DETAIL
  https://reviews.facebook.net/D7371

To: JIRA, navis
Cc: njain

                
> Implement TRUNCATE
> ------------------
>
>                 Key: HIVE-446
>                 URL: https://issues.apache.org/jira/browse/HIVE-446
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Prasad Chakka
>            Assignee: Navis
>         Attachments: HIVE-446.D7371.1.patch
>
>
> truncate the data but leave the table and metadata intact.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to