[
https://issues.apache.org/jira/browse/HIVE-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535044#comment-13535044
]
Mark Grover commented on HIVE-2693:
-----------------------------------
I added some test data and more tests to patch12 and found a few more
interesting issues:
1. I added new tests related to where clauses. The where clause doesn't seem to
be working as expected. I will take another look to see if I am doing something
wrong but that's my first impression anyways.
2. I added more test data where the decimal column has values like 3.14 and
3.140. This is an interesting case since we would like to maintain
compatibility with MySQL where possible. If I remember correctly (from a few
days ago when I tried it), MySQL considers 3.14 and 3.140 to be equivalent.
Therefore, they would be considered the same in equi-join, where clauses, etc.
This addition of a new data led me to see that order by is non-deterministic
when done over a decimal column. Again something, we should look more into.
FWIW, 3.14 are correctly being joined to 3.140 rows, so that's good!
3. I added some more test data with NULLs for the decimal column to make sure
those were being read and handled properly when the table was being loaded.
I will submit a new patch with these added tests and data shortly.
[~hagleitn] About patch 12, do we need to have a separate sign (0) for zero?
Would it not suffice for it to use the same sign as positive numbers? That
would make it consistent with other datatypes as well. Been having a little
busy morning but will review the rest of the patch shortly!
> Add DECIMAL data type
> ---------------------
>
> Key: HIVE-2693
> URL: https://issues.apache.org/jira/browse/HIVE-2693
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor, Types
> Affects Versions: 0.10.0
> Reporter: Carl Steinbach
> Assignee: Prasad Mujumdar
> Attachments: 2693_7.patch, 2693_8.patch, 2693_fix_all_tests1.patch,
> HIVE-2693-10.patch, HIVE-2693-11.patch, HIVE-2693-12-SortableSerDe.patch,
> HIVE-2693-1.patch.txt, HIVE-2693-all.patch, HIVE-2693-fix.patch,
> HIVE-2693.patch, HIVE-2693-take3.patch, HIVE-2693-take4.patch
>
>
> Add support for the DECIMAL data type. HIVE-2272 (TIMESTAMP) provides a nice
> template for how to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
