[
https://issues.apache.org/jira/browse/HIVE-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549059#comment-13549059
]
Phabricator commented on HIVE-3799:
-----------------------------------
zhenxiao has commented on the revision "HIVE-3799 [jira] Better error message
if metalisteners or hookContext cannot be loaded/instantiated".
Looks good.
Is it possible to create a negative testcase to verify the exception?
REVISION DETAIL
https://reviews.facebook.net/D7719
To: JIRA, navis
Cc: zhenxiao
> Better error message if metalisteners or hookContext cannot be
> loaded/instantiated
> ----------------------------------------------------------------------------------
>
> Key: HIVE-3799
> URL: https://issues.apache.org/jira/browse/HIVE-3799
> Project: Hive
> Issue Type: Improvement
> Components: Diagnosability, Logging
> Affects Versions: 0.9.0
> Reporter: Sudhanshu Arora
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-3799.D7719.1.patch
>
>
> If I am not able to instantiate MetaListener or HookContext because of some
> dependent class missing, the only error I get is InvocationTargetException.
> MetaStoreUtils.getMetaListener should be changed as following:
> try {
> T listener = (T) Class.forName(
> listenerImpl.trim(), true,
> JavaUtils.getClassLoader()).getConstructor(
> Configuration.class).newInstance(conf);
> listeners.add(listener);
> } catch (InvocationTargetException e) {
> throw new MetaException("Failed to instantiate listener named: "+
> listenerImpl + " reason: " + e.getCause().toString());
> } catch (Exception e) {
> throw new MetaException("Failed to instantiate listener named: "+
> listenerImpl + " reason: " + e.toString());
> }
> Similarly Driver.getHooks should be changed to handle
> InvocationTargetException in a better way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
