[
https://issues.apache.org/jira/browse/HIVE-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549398#comment-13549398
]
Phabricator commented on HIVE-3797:
-----------------------------------
zhenxiao has commented on the revision "HIVE-3797 [jira] Add option for hive
server to initialize and add resources registered to it to clients".
How about create a sample initialization script, and have an example testcase
running it?
Also, is it possible to create a testcase to show that HiveServer's resource
could be usable for clients(this testcase maybe not easy to do)?
INLINE COMMENTS
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:765 Some
comments here? eg. Load Hive Server SQL initialization scripts
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:785 Some
comments for this function?
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:800 Some
general comments about init script line processing?
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:822 Is it
IllegalStateException, or IllegalArgumentException?
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:826 same as
above. What type of exception should we throw?
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:607
useServerResources initialized to be false.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:695
useServerResources is not initialized. It should be initialized to be false.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:626 Could it
be better if "Hive Server Initialization Script File"?
service/src/java/org/apache/hadoop/hive/service/HiveServer.java:147 Is it
better to have a different function name to create temporary hive server
handler?
using a private Constructor seems a little misleading. How about just call it
createTemporaryHandler()?
REVISION DETAIL
https://reviews.facebook.net/D7353
To: JIRA, navis
Cc: zhenxiao
> Add option for hive server to initialize and add resources registered to it
> to clients
> --------------------------------------------------------------------------------------
>
> Key: HIVE-3797
> URL: https://issues.apache.org/jira/browse/HIVE-3797
> Project: Hive
> Issue Type: Improvement
> Components: Server Infrastructure
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-3797.D7353.1.patch
>
>
> CliDriver has -i option for initializing the session. HiveServer also should
> have one and make resources usable for clients if needed.
> hive --service hiveserver -i init.q -u
> -i for init script
> -u for publishing resources(file,jar,etc.) to clients
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
