> On Jan. 17, 2013, 1:55 a.m., Brock Noland wrote: > > Hi, Looks good! A few more comments below. "Sorry for ignorance of git > > and shamelessly cloning the code" - no worries :) if you didn't copy this > > I'd wonder why not! > > > > Also, FYI I am not a Hive committer.
Thank you very much for your comments no matter whether you are a commiter or not. > On Jan. 17, 2013, 1:55 a.m., Brock Noland wrote: > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, > > line 474 > > <https://reviews.apache.org/r/8958/diff/2/?file=248840#file248840line474> > > > > What is the purpose of this cast? Also, this will be closed in the > > finally, block, no? > > I think the cast is to remind (make sure) that we calls the correct method. And this kind of close are involved by HIVE-1884 to avoid potential risk of resource leaks in Hive, I think... - Zhuoluo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8958/#review15438 ----------------------------------------------------------- On Jan. 18, 2013, 6:28 a.m., Zhuoluo Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8958/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2013, 6:28 a.m.) > > > Review request for hive, Carl Steinbach and Brock Noland. > > > Description > ------- > > We add a simple ddl grammar, called "show version". > The version info is generated automatically while compiling. > > > This addresses bug HIVE-1151. > https://issues.apache.org/jira/browse/HIVE-1151 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/hive/trunk/bin/ext/version.sh PRE-CREATION > http://svn.apache.org/repos/asf/hive/trunk/bin/hive 1435001 > http://svn.apache.org/repos/asf/hive/trunk/build.xml 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java > 1435001 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java > PRE-CREATION > http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh > PRE-CREATION > > Diff: https://reviews.apache.org/r/8958/diff/ > > > Testing > ------- > > zhuoluo@zhuoluo-Latitude-E6420:~$ hive --version > Hive 0.11.0-SNAPSHOT > Subversion git://github.com/apache/hive.git on branch trunk -r > 34c95e9e6ab2110653af20e6d34a8fe02b04198d > Compiled by zhuoluo on Wed Jan 16 12:26:12 CST 2013 > zhuoluo@zhuoluo-Latitude-E6420:~$ hive > Hive history > file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301161232_1201027344.txt > hive> show version; > OK > 0.11.0-SNAPSHOT from 34c95e9e6ab2110653af20e6d34a8fe02b04198d by zhuoluo on > Wed Jan 16 12:26:12 CST 2013 > git://github.com/apache/hive.git on branch trunk > Time taken: 0.522 seconds, Fetched: 2 row(s) > hive> > > > Thanks, > > Zhuoluo Yang > >
