[
https://issues.apache.org/jira/browse/HIVE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558066#comment-13558066
]
Phabricator commented on HIVE-3628:
-----------------------------------
njain has commented on the revision "HIVE-3628 [jira] Provide a way to use
counters in Hive through UDF".
INLINE COMMENTS
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/DummyContextUDF.java:1
apache header missing
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/ContextualUDF.java:23 Can
you add some comments as to what is this needed for ?
ql/src/test/queries/clientpositive/udf_context_aware.q:3 use
bucketizedinputformat to make the test deterministic, just in case more than a
single mapper gets used for src
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/ContextualUDF.java:1 Do you
really need ContextualUDF ?
I mean, can you add a annotation in GenericUDF ?
Or, add a init(ExecutionContext) method in GenericUDF ? The method with the
counter
can override init().
Think about it - if you think it is too complex, adding a new interface is
also OK.
REVISION DETAIL
https://reviews.facebook.net/D8007
To: JIRA, navis
Cc: njain
> Provide a way to use counters in Hive through UDF
> -------------------------------------------------
>
> Key: HIVE-3628
> URL: https://issues.apache.org/jira/browse/HIVE-3628
> Project: Hive
> Issue Type: Improvement
> Components: UDF
> Reporter: Viji
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-3628.D8007.1.patch, HIVE-3628.D8007.2.patch
>
>
> Currently it is not possible to generate counters through UDF. We should
> support this.
> Pig currently allows this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
