[
https://issues.apache.org/jira/browse/HIVE-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558533#comment-13558533
]
Phabricator commented on HIVE-3849:
-----------------------------------
njain has commented on the revision "HIVE-3849 [jira] Columns are not extracted
for multi-groupby single reducer case somtimes".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:8704 Can
you fix the comments ?
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:8654 Can
you add some comments for this function ?
Detailed comments would really help in maintaining it in the long term.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:3571 Either
change the name of the function or add a lot of comments.
You are not removing from keys, from removing keys from the mapping passed in.
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:3540 Add
some comments here.
Some of the expressions are already passed in the reduce Keys - they need not
be
passed again in the values. A example query would really help.
REVISION DETAIL
https://reviews.facebook.net/D7713
To: JIRA, navis
Cc: njain
> Aliased column in where clause for multi-groupby single reducer cannot be
> resolved
> ----------------------------------------------------------------------------------
>
> Key: HIVE-3849
> URL: https://issues.apache.org/jira/browse/HIVE-3849
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-3849.D7713.1.patch, HIVE-3849.D7713.2.patch,
> HIVE-3849.D7713.3.patch, HIVE-3849.D7713.4.patch, HIVE-3849.D7713.5.patch
>
>
> Verifying HIVE-3847, I've found an exception is thrown before meeting the
> error situation described in it. Something like,
> FAILED: SemanticException [Error 10025]: Line 40:6 Expression not in GROUP BY
> key 'crit5'
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
