[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559914#comment-13559914
]
Ashutosh Chauhan commented on HIVE-2340:
----------------------------------------
Thanks, Navis for updating the patch. I haven't looked the patch in detail, but
some comments:
* In the latest patch, you have removed rule {{RS%.*RS%GBY%}} and
{{RS%GBY%.*RS%GBY%}} and have modified rule {{JOIN%.*RS%GBY%}} to
{{JOIN%.*%RS%}} Can you shed some light on thinking behind picking these rules?
Were those rules not stable or you think they are not useful?
* auto_join_26.q.out is incorrect, its generating wrong results. Looks like
aggregation is not happening correctly.
* I haven't ran full suite, but queries groupby_grouping_sets5.q and
smb_mapjoin_14.q are failing after applying this patch.
> optimize orderby followed by a groupby
> --------------------------------------
>
> Key: HIVE-2340
> URL: https://issues.apache.org/jira/browse/HIVE-2340
> Project: Hive
> Issue Type: Sub-task
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Labels: perfomance
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.1.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.2.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.3.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.4.patch,
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.5.patch, HIVE-2340.1.patch.txt,
> HIVE-2340.D1209.6.patch
>
>
> Before implementing optimizer for JOIN-GBY, try to implement RS-GBY
> optimizer(cluster-by following group-by).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
