[ 
https://issues.apache.org/jira/browse/HIVE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-3981:
-----------------------------------

    Attachment: hive-3981_2.patch

Patch with ptf_seqfile.q.out and ptf_rcfile.q.out 

Harish,
* patch files are txt files, they don't usually contain binary data, so part.rc 
and part.seq data are not contained in your patch file.
* -Dqfile is capable of handling multiple q files in one run, so contributors 
can specify -Dqfile=ptf_general_queries.q,ptf_rcfile.q,ptf_seqfile.q so it 
shouldn't be too hard for contributors to ensure they have run all tests.
* Running tests in-process is a good idea but has implication for whole of hive 
project so probably needs to be discussed in seperate jira 
                
> Split up tests in ptf_general_queries.q
> ---------------------------------------
>
>                 Key: HIVE-3981
>                 URL: https://issues.apache.org/jira/browse/HIVE-3981
>             Project: Hive
>          Issue Type: Task
>          Components: PTF-Windowing
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: hive-3981_2.patch, hive-3981.patch, part.rc, part.seq
>
>
> ptf_general_queries.q has 62 queries currently and it takes nearly 20 minutes 
> on my laptop to finish. I think we should break it down in smaller .q files 
> otherwise adding a new query and debugging it will be a pain. I have split 
> out rcfile and seqfile tests from it to begin. Also, this test currently 
> fails because original patch didn't had .rc and .seq files (they were 
> binary). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to