[
https://issues.apache.org/jira/browse/HIVE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576839#comment-13576839
]
Phabricator commented on HIVE-701:
----------------------------------
sxyuan has commented on the revision "HIVE-701 [jira] Make keywords
non-reserved".
Highlighting the main changes.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:302 Moved from
ParseDriver.
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g:496 Main
change for making keywords non-reserved. Future non-reserved keywords should be
added to the nonReserved rule.
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:1154 Alternatives
reordered to make identifier come last.
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g:1161 Same as above.
ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g:36 gParent is
an ANTLR-defined variable referring to the importing parser. The delegate
parsers all refer to HiveParser for custom error handling.
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g:174 Reordered.
REVISION DETAIL
https://reviews.facebook.net/D8397
To: kevinwilfong, JIRA, sxyuan
Cc: njain
> lots of reserved keywords in hive
> ---------------------------------
>
> Key: HIVE-701
> URL: https://issues.apache.org/jira/browse/HIVE-701
> Project: Hive
> Issue Type: New Feature
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Samuel Yuan
> Attachments: HIVE-701.1.patch.txt, HIVE-701.2.patch.txt,
> HIVE-701.D8397.1.patch, HIVE-701.HIVE-701.D8397.2.patch
>
>
> There is a problem if we want to use some reserved keywords:
> for example, creating a function of name left/right ? left/right is already a
> reserved keyword.
> The other way around should also be possible - if we want to add a 'show
> tables status' and some applications already use status as a column name,
> they should not break
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
