[
https://issues.apache.org/jira/browse/HIVE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588612#comment-13588612
]
Phabricator commented on HIVE-4080:
-----------------------------------
hbutani has commented on the revision "HIVE-4080 [jira] Add Lead & Lag UDAFs".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:866 Yes, i
wanted to introduce a new fn to take a GenericUDAFResolver: public static
GenericUDAFEvaluator getGenericUDAFEvaluator(GenericUDAFResolver,
List<ObjectInspector> argumentOIs, boolean isDistinct,
boolean isAllColumns)
and have the current getGenericUDAFEvaluator and getGenericWindowingEvaluator
call it.
But backed out, because was not comfortable making this change and submitting
the patch w/o running the entire test suite.
Ended up just doing a cut and paste. Your soln is much better
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1467 Yes,
meant to do this. Somehow forgot, sorry
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFLag.java:29 yes,
i was rushing this...
should refactor it.
ql/src/test/queries/clientpositive/leadlag_queries.q:20 yes exactly
ql/src/test/queries/clientpositive/leadlag_queries.q:35 will add
REVISION DETAIL
https://reviews.facebook.net/D8961
BRANCH
HIVE-4080
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, hbutani
> Add Lead & Lag UDAFs
> --------------------
>
> Key: HIVE-4080
> URL: https://issues.apache.org/jira/browse/HIVE-4080
> Project: Hive
> Issue Type: Bug
> Components: PTF-Windowing
> Reporter: Harish Butani
> Assignee: Harish Butani
> Attachments: HIVE-4080.1.patch.txt, HIVE-4080.D8961.1.patch
>
>
> Currently we support Lead/Lag as navigation UDFs usable with Windowing.
> To be standard compliant we need to support Lead & Lag UDAFs.
> Will continue to support Lead/Lag UDFs as arguments to UDAFs when Windowing
> is in play.
> Currently allow Lead/Lag expressions to appear in SelectLists even when they
> are not arguments to UDAFs. Support for this feature will probably be
> removed. Causes ambiguities when Query contains different partition clauses.
> Will provide more details with associated Jira to remove this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
