[ https://issues.apache.org/jira/browse/HIVE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607162#comment-13607162 ]
Sushanth Sowmyan commented on HIVE-3938: ---------------------------------------- Looks good to me. +1 (non-binding) One thing I will note, however, for the sake of completeness, in that this is a behaviour change, is that this implementation of taking the common table out of the partitions means that add_partitions will only work if all the partitions in parts are in the same table. The earlier implementation allowed a mixed group of partitions. I think this is better though, and atomically adding arbitrary groups of partitions atomically if they're not related is a recipe for other usage problems. > Hive MetaStore should send a single AddPartitionEvent for atomically added > partition-set. > ----------------------------------------------------------------------------------------- > > Key: HIVE-3938 > URL: https://issues.apache.org/jira/browse/HIVE-3938 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 0.10.0 > Reporter: Mithun Radhakrishnan > Assignee: Mithun Radhakrishnan > Attachments: HIVE-3938.trunk.patch > > > HiveMetaStore::add_partitions() currently adds all partitions specified in > one call using a single meta-store transaction. This acts correctly. However, > there's one AddPartitionEvent created per partition specified. > Ideally, the set of partitions added atomically can be communicated using a > single AddPartitionEvent, such that they are consumed together. > I'll post a patch that does this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira