[
https://issues.apache.org/jira/browse/HIVE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620402#comment-13620402
]
Phabricator commented on HIVE-4120:
-----------------------------------
hagleitn has commented on the revision "HIVE-4120 [jira] Implement decimal
encoding for ORC".
Looks good to me. Only minor comment: It would be nice if there was an end to
end test (i.e.: a .q file with an orc + decimal table.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java:438 no
need to copy the bigdecimal for min, max and sum, they're immutable me thinks.
REVISION DETAIL
https://reviews.facebook.net/D9207
To: JIRA, omalley
Cc: hagleitn
> Implement decimal encoding for ORC
> ----------------------------------
>
> Key: HIVE-4120
> URL: https://issues.apache.org/jira/browse/HIVE-4120
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-4120.D9207.1.patch
>
>
> Currently, ORC does not have an encoder for decimal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
