----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10312/#review18732 -----------------------------------------------------------
ql/src/test/results/clientpositive/input5.q.out <https://reviews.apache.org/r/10312/#comment39153> Couldn't understand the reason how come this change may affect the ordering of rows. Do you have any insight? serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java <https://reviews.apache.org/r/10312/#comment39154> seems like serde's could have stored custom representation of null in properties which would have been used, aren't we taking away that capability now? serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java <https://reviews.apache.org/r/10312/#comment39155> Bit confusing to me. JSON_NULL is still null, how come than we have NULL being printed now. - Ashutosh Chauhan On April 5, 2013, 6:32 p.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10312/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 6:32 p.m.) > > > Review request for hive. > > > Description > ------- > > HIVE-3840 -hive cli null representation in output is inconsistent > > > This addresses bug HIVE-3840. > https://issues.apache.org/jira/browse/HIVE-3840 > > > Diffs > ----- > > ql/src/test/results/clientpositive/avro_nullable_fields.q.out 4f48fbf > ql/src/test/results/clientpositive/columnarserde_create_shortcut.q.out > f4b2830 > ql/src/test/results/clientpositive/create_nested_type.q.out 9c44708 > ql/src/test/results/clientpositive/input17.q.out db02dfa > ql/src/test/results/clientpositive/input5.q.out 3ea7a70 > ql/src/test/results/clientpositive/input_columnarserde.q.out defec4c > ql/src/test/results/clientpositive/input_dynamicserde.q.out b22aa45 > ql/src/test/results/clientpositive/input_lazyserde.q.out f5fe60a > ql/src/test/results/clientpositive/input_testxpath3.q.out aa81734 > ql/src/test/results/clientpositive/join_thrift.q.out 2ed9f61 > ql/src/test/results/clientpositive/udf_percentile.q.out f3b2cfc > ql/src/test/results/clientpositive/udf_substr.q.out a7e690f > ql/src/test/results/clientpositive/udtf_stack.q.out fe57cd1 > serde/src/java/org/apache/hadoop/hive/serde2/DelimitedJSONSerDe.java > b728b18 > serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 4954b29 > > Diff: https://reviews.apache.org/r/10312/diff/ > > > Testing > ------- > > unit tests updated > > > Thanks, > > Thejas Nair > >
