[
https://issues.apache.org/jira/browse/HIVE-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4344:
------------------------------
Attachment: HIVE-4344.HIVE-4344.HIVE-4344.HIVE-4344.D10221.1.patch
sxyuan requested code review of "HIVE-4344 [jira] CREATE VIEW fails when
redundant casts are rewritten".
Reviewers: kevinwilfong
See JIRA for a description of the problem. This change relaxes the constraints
on translations. Previously, if a new translation overlaps with an existing
one, one must be a prefix or suffix of the other. This allows the case when one
is completely contained inside the other.
TEST PLAN
Run tests.
REVISION DETAIL
https://reviews.facebook.net/D10221
AFFECTED FILES
ql/src/test/results/clientpositive/create_view_translate.q.out
ql/src/test/queries/clientpositive/create_view_translate.q
ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/24441/
To: kevinwilfong, sxyuan
Cc: sambavim, JIRA
> CREATE VIEW fails when redundant casts are rewritten
> ----------------------------------------------------
>
> Key: HIVE-4344
> URL: https://issues.apache.org/jira/browse/HIVE-4344
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.11.0
> Reporter: Samuel Yuan
> Assignee: Samuel Yuan
> Attachments: HIVE-4344.HIVE-4344.HIVE-4344.HIVE-4344.D10221.1.patch
>
>
> e.g. create view v as select cast(key as string) from src;
> The rewriter tries to replace both cast(key as string) and key as
> `src`.`key`, because cast(key as string) is a no-op.
> There may be other cases like this one.
> See HIVE-2439 for context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
