[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631971#comment-13631971
]
Jitendra Nath Pandey commented on HIVE-4284:
--------------------------------------------
A few comments on the patch.
- Some files seem to have tab characters, the indentation is longer than two
spaces.
- Please limit the length of a line to 80 chars.
- Javadocs are not correctly formatted in many places, and please make sure all
public methods have a javadoc.
- There are some test fields in BytesColumnVector, can that be avoided?
- There is code to load random data into VectorizedRowBatch for testing. Since
these are public classes, its better to provide test utilities to load random
data instead of putting code in the classes themselves.
> Implement class for vectorized row batch
> ----------------------------------------
>
> Key: HIVE-4284
> URL: https://issues.apache.org/jira/browse/HIVE-4284
> Project: Hive
> Issue Type: Sub-task
> Reporter: Jitendra Nath Pandey
> Assignee: Eric Hanson
> Attachments: HIVE-4284.1.patch
>
>
> Vectorized row batch object will represent the row batch that vectorized
> operators will work on. Refer to design spec attached to HIVE-4160 for
> details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
