[
https://issues.apache.org/jira/browse/HIVE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632928#comment-13632928
]
Phabricator commented on HIVE-4130:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-4130 [jira] Bring the
Lead/Lag UDFs interface in line with Lead/Lag UDAFs".
Couple more comments.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java:98
Shouldn't the default value of amt be 1 ?
ql/src/test/queries/clientpositive/windowing_expressions.q:38 It will be good
to add a testcase which exercises non-default values like
sum(lag(p_retailprice,3,29.43))
REVISION DETAIL
https://reviews.facebook.net/D10233
BRANCH
HIVE-4130
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, hbutani
> Bring the Lead/Lag UDFs interface in line with Lead/Lag UDAFs
> -------------------------------------------------------------
>
> Key: HIVE-4130
> URL: https://issues.apache.org/jira/browse/HIVE-4130
> Project: Hive
> Issue Type: Bug
> Components: PTF-Windowing
> Reporter: Harish Butani
> Assignee: Harish Butani
> Attachments: HIVE-4130.D10233.1.patch, HIVE-4130.D10233.2.patch
>
>
> - support a default value arg
> - both amt and defaultValue args can be optional
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
