----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10592/#review19379 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java <https://reviews.apache.org/r/10592/#comment40093> These comments violate the coding conventions. ColumnVector and VectorizedRowBatch have the same problem. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java <https://reviews.apache.org/r/10592/#comment40092> Move the constant 1.2 to a static final float and refer to it by name. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java <https://reviews.apache.org/r/10592/#comment40091> Formatting ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java <https://reviews.apache.org/r/10592/#comment40090> Please throw a runtime exception here instead of relying on asserts (which can be disabled). ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java <https://reviews.apache.org/r/10592/#comment40089> Please correct the formatting issues in this file. - Carl Steinbach On April 18, 2013, 1:27 a.m., Eric Hanson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10592/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 1:27 a.m.) > > > Review request for hive. > > > Description > ------- > > New code for VectorizedRowBatch to form basis of vectorized query execution > > > This addresses bug HIVE-4284. > https://issues.apache.org/jira/browse/HIVE-4284 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10592/diff/ > > > Testing > ------- > > > Thanks, > > Eric Hanson > >
