[
https://issues.apache.org/jira/browse/HIVE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4377:
------------------------------
Attachment: HIVE-4377.D10377.1.patch
navis requested code review of "HIVE-4377 [jira] Add more comment to
https://reviews.facebook.net/D1209 (HIVE-2340)".
Reviewers: JIRA
HIVE-4377 Add more comment to https://reviews.facebook.net/D1209 (HIVE-2340)
thanks a lot for addressing optimization in HIVE-2340. Awesome!
Since we are developing at a very fast pace, it would be really useful to
think about maintainability and testing of the large codebase. Highlights which
are applicable for D1209:
1. Javadoc for all public/private functions, except for
setters/getters. For any complex function, clear examples (input/output)
would really help.
2. Specially, for query optimizations, it might be a good idea to have
a simple working query at the top, and the expected changes. For e.g..
The operator tree for that query at each step, or a detailed explanation
at the top.
3. If possible, the test name (.q file) where the function is being
invoked, or the query which would potentially test that scenario, if it
is a query processor change.
4. Comments in each test (.q file) that should include the jira
number, what is it trying to test. Assumptions about each query.
5. Reduce the output for each test whenever query is outputting more
than 10 results, it should have a reason. Otherwise, each query result
should be bounded by 10 rows.
thanks a lot
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D10377
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/24849/
To: JIRA, navis
> Add more comment to https://reviews.facebook.net/D1209 (HIVE-2340)
> ------------------------------------------------------------------
>
> Key: HIVE-4377
> URL: https://issues.apache.org/jira/browse/HIVE-4377
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Gang Tim Liu
> Assignee: Navis
> Attachments: HIVE-4377.D10377.1.patch
>
>
> thanks a lot for addressing optimization in HIVE-2340. Awesome!
> Since we are developing at a very fast pace, it would be really useful to
> think about maintainability and testing of the large codebase. Highlights
> which are applicable for D1209:
> 1. Javadoc for all public/private functions, except for
> setters/getters. For any complex function, clear examples (input/output)
> would really help.
> 2. Specially, for query optimizations, it might be a good idea to have
> a simple working query at the top, and the expected changes. For e.g..
> The operator tree for that query at each step, or a detailed explanation
> at the top.
> 3. If possible, the test name (.q file) where the function is being
> invoked, or the query which would potentially test that scenario, if it
> is a query processor change.
> 4. Comments in each test (.q file) that should include the jira
> number, what is it trying to test. Assumptions about each query.
> 5. Reduce the output for each test whenever query is outputting more
> than 10 results, it should have a reason. Otherwise, each query result
> should be bounded by 10 rows.
> thanks a lot
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
