[ 
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637860#comment-13637860
 ] 

Phabricator commented on HIVE-2340:
-----------------------------------

njain has commented on the revision "HIVE-2340 [jira] optimize orderby followed 
by a groupby".

INLINE COMMENTS
  ql/src/test/queries/clientpositive/reduce_deduplicate.q:26 can you add more 
comments here ??

  who sets trustScript ?
  As a user, how can i do that
  What is supposed to happen.
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java:124
 Can you add more comments here ?

  Is minReducer only set for order By ?

REVISION DETAIL
  https://reviews.facebook.net/D1209

BRANCH
  DPAL-592

ARCANIST PROJECT
  hive

To: JIRA, hagleitn, navis
Cc: hagleitn, njain

                
> optimize orderby followed by a groupby
> --------------------------------------
>
>                 Key: HIVE-2340
>                 URL: https://issues.apache.org/jira/browse/HIVE-2340
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>              Labels: perfomance
>             Fix For: 0.11.0
>
>         Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.1.patch, 
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.2.patch, 
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.3.patch, 
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.4.patch, 
> ASF.LICENSE.NOT.GRANTED--HIVE-2340.D1209.5.patch, HIVE-2340.12.patch, 
> HIVE-2340.13.patch, HIVE-2340.14.patch, 
> HIVE-2340.14.rebased_and_schema_clone.patch, HIVE-2340.15.patch, 
> HIVE-2340.1.patch.txt, HIVE-2340.D1209.10.patch, HIVE-2340.D1209.11.patch, 
> HIVE-2340.D1209.12.patch, HIVE-2340.D1209.13.patch, HIVE-2340.D1209.14.patch, 
> HIVE-2340.D1209.15.patch, HIVE-2340.D1209.6.patch, HIVE-2340.D1209.7.patch, 
> HIVE-2340.D1209.8.patch, HIVE-2340.D1209.9.patch, testclidriver.txt
>
>
> Before implementing optimizer for JOIN-GBY, try to implement RS-GBY 
> optimizer(cluster-by following group-by).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to