----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10812/#review19822 -----------------------------------------------------------
common/build.xml <https://reviews.apache.org/r/10812/#comment40879> This extra property is only referenced in one place. I think it would be cleaner to remove it. common/src/scripts/saveVersion.sh <https://reviews.apache.org/r/10812/#comment40880> I think the output directory was correct to begin with. Please revert. jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java <https://reviews.apache.org/r/10812/#comment40881> The junit task in build-common.xml sets the hive.version sysproperty. I think it would be good to verify that HiveVersionInfo.getVersion(), meta.getDatabaseProductVersion(), and System.getProperty("hive.version") all match. - Carl Steinbach On April 27, 2013, 2:53 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10812/ > ----------------------------------------------------------- > > (Updated April 27, 2013, 2:53 a.m.) > > > Review request for hive. > > > Description > ------- > > HIVE-4373 > > > This addresses bug HIVE-4373. > https://issues.apache.org/jira/browse/HIVE-4373 > > > Diffs > ----- > > common/build.xml 731f26e > common/src/scripts/saveVersion.sh a917d4a > jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 3d1a969 > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 938dd9a > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 18594cb > > Diff: https://reviews.apache.org/r/10812/diff/ > > > Testing > ------- > > Unit test included. Also tested with remote HS2 server. > > > Thanks, > > Thejas Nair > >
