[
https://issues.apache.org/jira/browse/HIVE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4689:
------------------------------
Attachment: HIVE-4689.D11211.1.patch
navis requested code review of "HIVE-4689 [jira] For outerjoins,
joinEmitInterval might make wrong result".
Reviewers: JIRA
HIVE-4689 For outerjoins, joinEmitInterval might make wrong result
Alias filter tag is calculated for each group and used for outer joins. But if
joinEmitInterval is smaller than the group size, pre-matured alias filter tag
would be used and might introduce different(wrong) result.
It can be observed in join_1to1.q test but I cannot imagine proper solution
which does not override intention of joinEmitInterval. Should it be disabled
for outer joins?
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D11211
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java
ql/src/test/results/clientpositive/join_1to1.q.out
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/26691/
To: JIRA, navis
> For outerjoins, joinEmitInterval might make wrong result
> --------------------------------------------------------
>
> Key: HIVE-4689
> URL: https://issues.apache.org/jira/browse/HIVE-4689
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Attachments: HIVE-4689.D11211.1.patch
>
>
> Alias filter tag is calculated for each group and used for outer joins. But
> if joinEmitInterval is smaller than the group size, pre-matured alias filter
> tag would be used and might introduce different(wrong) result.
> It can be observed in join_1to1.q test but I cannot imagine proper solution
> which does not override intention of joinEmitInterval. Should it be disabled
> for outer joins?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
