[
https://issues.apache.org/jira/browse/HIVE-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-4733:
------------------------------
Attachment: HIVE-4733.D11277.1.patch
navis requested code review of "HIVE-4733 [jira] HiveLockObjectData is not
compared properly".
Reviewers: JIRA
HIVE-4733 HiveLockObjectData is not compared properly
ret = ret && (clientIp == null) ? target.getClientIp() == null :
clientIp.equals(target.getClientIp());
seemed intended to be
ret = ret && (clientIp == null ? target.getClientIp() == null :
clientIp.equals(target.getClientIp()));
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D11277
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/26811/
To: JIRA, navis
> HiveLockObjectData is not compared properly
> -------------------------------------------
>
> Key: HIVE-4733
> URL: https://issues.apache.org/jira/browse/HIVE-4733
> Project: Hive
> Issue Type: Bug
> Components: Locking
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Fix For: 0.12.0
>
> Attachments: HIVE-4733.D11277.1.patch
>
>
> {noformat}
> ret = ret && (clientIp == null) ? target.getClientIp() == null :
> clientIp.equals(target.getClientIp());
> {noformat}
> seemed intended to be
> {noformat}
> ret = ret && (clientIp == null ? target.getClientIp() == null :
> clientIp.equals(target.getClientIp()));
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
