----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11326/ -----------------------------------------------------------
(Updated June 27, 2013, 12:39 a.m.) Review request for hive. Changes ------- Additional comments for the new classes/interfaces Bugs: HIVE-4588 https://issues.apache.org/jira/browse/HIVE-4588 Repository: hive-git Description ------- Support session level hooks for HiveServer2 - New config parameter to define the hook - New hook context interface to pass the serssion user and config to the hook implementation - Session manager executes the configured hooks when a new session starts Diffs (updated) ----- beeline/src/java/org/apache/hive/beeline/Commands.java 3799cc1 beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java 030f6b0 build-common.xml d642b51 cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java d9b7031 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cc775d9 conf/hive-default.xml.template 5de5965 data/conf/hive-site.xml 4e6ff16 data/files/person c902284 hbase-handler/src/test/templates/TestHBaseCliDriver.vm c59e882 hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm aaab85b hcatalog/bin/hcat 455f108 hcatalog/core/src/test/java/org/apache/hcatalog/cli/TestSemanticAnalysis.java d7a2b68 hcatalog/src/docs/src/documentation/content/xdocs/readerwriter.xml e36090e hcatalog/src/test/e2e/hcatalog/build.xml 8cf7407 hcatalog/src/test/e2e/hcatalog/drivers/TestDriverHiveCmdLine.pm 6154475 hcatalog/src/test/e2e/hcatalog/resource/default.res 01bfaee hcatalog/src/test/e2e/hcatalog/resource/windows.res 01bfaee hcatalog/src/test/e2e/hcatalog/tests/hcat.conf fa7893b hcatalog/src/test/e2e/hcatalog/tests/hive_cmdline.conf 91c0786 hcatalog/src/test/e2e/hcatalog/tests/hive_nightly.conf d026872 hcatalog/src/test/e2e/hcatalog/tools/test/floatpostprocessor.pl ec5de96 hcatalog/src/test/e2e/templeton/README.txt dac6ffc hcatalog/src/test/e2e/templeton/build.xml 4bce25b hcatalog/src/test/e2e/templeton/resource/default.res 01bfaee hcatalog/src/test/e2e/templeton/resource/windows.res 01bfaee jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java 2859859 jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java 4c1ab3b jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 0e90fec jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 4cb1422 jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java 2576914 jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a7c432d jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java b142e8c jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java b108c7a metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 88151a1 ql/build.xml a34a079 ql/src/java/org/apache/hadoop/hive/ql/Context.java 5340e99 ql/src/java/org/apache/hadoop/hive/ql/Driver.java a5a867a ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java c796770 ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 6935738 ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java 854cd52 ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 38d97e3 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 295daab ql/src/java/org/apache/hadoop/hive/ql/exec/DependencyCollectionTask.java 9189cfc ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 11772e6 ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 5a00c2d ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java 5cd9bde ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java b4da80c ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 6e9e0a8 ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b4b2c90 ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 988b389 ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 6bbcb26 ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ac8e167 ql/src/java/org/apache/hadoop/hive/ql/exec/PTFOperator.java 90d93f6 ql/src/java/org/apache/hadoop/hive/ql/exec/PTFPartition.java 092be6e ql/src/java/org/apache/hadoop/hive/ql/exec/PTFPersistence.java c737d7a ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 599f63c ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 17387a9 ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java fcf9adc ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 68ec54a ql/src/java/org/apache/hadoop/hive/ql/index/IndexMetadataChangeTask.java 364fc19 ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java cbee423 ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java a1abf90 ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java a9cd8ac ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java f1d29f8 ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java e5df744 ql/src/java/org/apache/hadoop/hive/ql/optimizer/AvgPartitionSizeBasedBigTableSelectorForAutoSMJ.java 5320143 ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 4bbaf2b ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkDeDuplication.java f8b1313 ql/src/java/org/apache/hadoop/hive/ql/optimizer/TableSizeBasedBigTableSelectorForAutoSMJ.java b882f87 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java da9423e ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java 8e1bafe ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 4bfed0d ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b2da758 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 7191b14 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g c5b833f ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java c2981e8 ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java b42a425 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2339629 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 97454e4 ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java 680977c ql/src/java/org/apache/hadoop/hive/ql/plan/CreateMacroDesc.java 3c5a723 ql/src/java/org/apache/hadoop/hive/ql/plan/DropMacroDesc.java 3e2aefc ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java f968bc1 ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 69cda05 ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 616994e ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java a6e87c4 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java 9400962 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/NumDistinctValueEstimator.java 24159b8 ql/src/test/org/apache/hadoop/hive/ql/TestErrorMsg.java 0654a0a ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 81a3396 ql/src/test/org/apache/hadoop/hive/ql/parse/TestSemanticAnalyzerFactory.java 4a52efb ql/src/test/org/apache/hadoop/hive/ql/plan/TestCreateMacroDesc.java 00a24b9 ql/src/test/org/apache/hadoop/hive/ql/plan/TestDropMacroDesc.java bf8de5d ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFMacro.java 189bcab ql/src/test/queries/clientnegative/invalid_columns.q 14b3409 ql/src/test/queries/clientnegative/macro_unused_parameter.q 523710d ql/src/test/queries/clientpositive/authorization_8.q 67fcf31 ql/src/test/queries/clientpositive/auto_join32.q 289bfbc ql/src/test/queries/clientpositive/auto_join33.q 5c85842 ql/src/test/queries/clientpositive/combine2_win.q f6090bb ql/src/test/queries/clientpositive/ctas_colname.q c174b11 ql/src/test/queries/clientpositive/groupby_grouping_sets4.q 25f1fcd ql/src/test/queries/clientpositive/join32_lessSize.q 58a26c5 ql/src/test/queries/clientpositive/join_vc.q 63b3da7 ql/src/test/queries/clientpositive/list_bucket_query_oneskew_1.q 7769fb7 ql/src/test/queries/clientpositive/list_bucket_query_oneskew_2.q 6a6945d ql/src/test/queries/clientpositive/list_bucket_query_oneskew_3.q 892b4c5 ql/src/test/queries/clientpositive/load_file_with_space_in_the_name.q 3b8951a ql/src/test/queries/clientpositive/load_hdfs_file_with_space_in_the_name.q e7eb8d9 ql/src/test/queries/clientpositive/macro.q fd0f7f2 ql/src/test/queries/clientpositive/multi_insert_lateral_view.q eb1b9ed ql/src/test/queries/clientpositive/orc_createas1.q 8726925 ql/src/test/queries/clientpositive/orc_diff_part_cols.q cbfd7b3 ql/src/test/queries/clientpositive/rcfile_default_format.q e61292e ql/src/test/queries/clientpositive/reduce_deduplicate_extended.q a5e9cdf ql/src/test/queries/clientpositive/truncate_column.q d756b47 ql/src/test/queries/clientpositive/truncate_column_merge.q a7aab35 ql/src/test/queries/negative/macro_reserved_word.q 359eb9d ql/src/test/results/clientnegative/invalid_columns.q.out ccc17d9 ql/src/test/results/clientnegative/macro_unused_parameter.q.out 5f093ad ql/src/test/results/clientnegative/recursive_view.q.out 1171fa8 ql/src/test/results/clientpositive/alter_view_rename.q.out d6838f5 ql/src/test/results/clientpositive/authorization_8.q.out b66fabc ql/src/test/results/clientpositive/auto_join14.q.out ecb6216 ql/src/test/results/clientpositive/auto_join32.q.out 312664a ql/src/test/results/clientpositive/auto_join33.q.out 8fc0e84 ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 3d51ef6 ql/src/test/results/clientpositive/combine2.q.out 1d51def ql/src/test/results/clientpositive/combine2_win.q.out 5d5042d ql/src/test/results/clientpositive/compute_stats_double.q.out 3456d58 ql/src/test/results/clientpositive/compute_stats_long.q.out bb1aa6d ql/src/test/results/clientpositive/compute_stats_string.q.out 814024a ql/src/test/results/clientpositive/ctas_colname.q.out c72dee1 ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out 8adcc04 ql/src/test/results/clientpositive/input12.q.out 8369cdc ql/src/test/results/clientpositive/input39.q.out b727e92 ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c ql/src/test/results/clientpositive/join32_lessSize.q.out 82b3e4a ql/src/test/results/clientpositive/join_vc.q.out f1433f3 ql/src/test/results/clientpositive/list_bucket_query_oneskew_1.q.out ced0500 ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out f8d8b3f ql/src/test/results/clientpositive/list_bucket_query_oneskew_3.q.out d55fd84 ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b ql/src/test/results/clientpositive/load_file_with_space_in_the_name.q.out b159114 ql/src/test/results/clientpositive/load_hdfs_file_with_space_in_the_name.q.out 1e7fa33 ql/src/test/results/clientpositive/macro.q.out 3d74674 ql/src/test/results/clientpositive/multiMapJoin1.q.out 3b3eb3f ql/src/test/results/clientpositive/multi_insert_lateral_view.q.out 12fa06b ql/src/test/results/clientpositive/orc_createas1.q.out 5d9b662 ql/src/test/results/clientpositive/orc_diff_part_cols.q.out 93bc891 ql/src/test/results/clientpositive/rcfile_default_format.q.out 6ad7f0b ql/src/test/results/clientpositive/recursive_dir.q.out 1baf1fa ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out 3297ebb ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out b3cce15 ql/src/test/results/clientpositive/skewjoin_union_remove_1.q.out a8f02fa ql/src/test/results/clientpositive/skewjoin_union_remove_2.q.out d1a30b4 ql/src/test/results/clientpositive/truncate_column.q.out 84be87c ql/src/test/results/clientpositive/truncate_column_merge.q.out bfb0340 ql/src/test/results/compiler/errors/macro_reserved_word.q.out 4e43a3f ql/src/test/results/compiler/plan/join1.q.xml 0c163cb ql/src/test/results/compiler/plan/join3.q.xml 20104b0 ql/src/test/templates/TestNegativeCliDriver.vm 9078ae5 serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java 41d36d7 service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java 85abba7 service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java bafe40c service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java d9d0e9c service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java 0a8825e service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 976a1ef service/src/java/org/apache/hive/service/cli/session/HiveSessionHook.java PRE-CREATION service/src/java/org/apache/hive/service/cli/session/HiveSessionHookContext.java PRE-CREATION service/src/java/org/apache/hive/service/cli/session/HiveSessionHookContextImpl.java PRE-CREATION service/src/java/org/apache/hive/service/cli/session/SessionManager.java 3bb6807 service/src/test/org/apache/hive/service/cli/session/TestSessionHooks.java PRE-CREATION Diff: https://reviews.apache.org/r/11326/diff/ Testing ------- Added new test for session hooks Thanks, Prasad Mujumdar