[
https://issues.apache.org/jira/browse/HIVE-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2702:
------------------------------
Attachment: HIVE-2702.D11715.1.patch
sershe requested code review of "HIVE-2702 [jira] listPartitionsByFilter only
supports string partitions".
Reviewers: JIRA
initial changes and tests, this time posting to Phabricator; compared to
previous patch in the JIRA, added testing, as well as support for negative
numbers.
I will run some perf tests, locally on derby it seems to work well.
listPartitionsByFilter supports only non-string partitions. This is because its
explicitly specified in generateJDOFilterOverPartitions in ExpressionTree.java.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D11715
AFFECTED FILES
metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java
metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
MANAGE HERALD RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/27771/
To: JIRA, sershe
> listPartitionsByFilter only supports string partitions
> ------------------------------------------------------
>
> Key: HIVE-2702
> URL: https://issues.apache.org/jira/browse/HIVE-2702
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.8.1
> Reporter: Aniket Mokashi
> Assignee: Sergey Shelukhin
> Attachments: ASF.LICENSE.NOT.GRANTED--HIVE-2702.D2043.1.patch,
> HIVE-2702.1.patch, HIVE-2702.D11715.1.patch, HIVE-2702-v0.patch
>
>
> listPartitionsByFilter supports only non-string partitions. This is because
> its explicitly specified in generateJDOFilterOverPartitions in
> ExpressionTree.java.
> //Can only support partitions whose types are string
> if( ! table.getPartitionKeys().get(partitionColumnIndex).
>
> getType().equals(org.apache.hadoop.hive.serde.Constants.STRING_TYPE_NAME) ) {
> throw new MetaException
> ("Filtering is supported only on partition keys of type string");
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
