[ https://issues.apache.org/jira/browse/HIVE-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714160#comment-13714160 ]
Hive QA commented on HIVE-4877: ------------------------------- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12593234/HIVE-4877.patch {color:green}SUCCESS:{color} +1 2646 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/98/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/98/console Messages: {noformat} Executing org.apache.hive.ptest.execution.CleanupPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. > In ExecReducer, remove tag from the row which will be passed to the first > Operator at the Reduce-side > ----------------------------------------------------------------------------------------------------- > > Key: HIVE-4877 > URL: https://issues.apache.org/jira/browse/HIVE-4877 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Affects Versions: 0.12.0 > Reporter: Yin Huai > Assignee: Yin Huai > Attachments: HIVE-4877.1.patch, HIVE-4877.patch > > > In ExecReducer, we can see ... > {code} > row.clear(); > row.add(keyObject); > row.add(valueObject[tag.get()]); > // The tag is not used any more, we should remove it. > row.add(tag); > {\code} > I have seen this for a long time. Actually, we are using > {code} > reducer.process(row, tag.get()); > {\code} > to pass the tag. > If we do not need to add the tag to a row, we should remove it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira