[
https://issues.apache.org/jira/browse/HIVE-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yin Huai updated HIVE-4877:
---------------------------
Attachment: HIVE-4877.patch
A minor update. In TestExecDriver, we should use LogFactory.getLog for logging.
Seems using LogFactory.getLog is the convention.
> In ExecReducer, remove tag from the row which will be passed to the first
> Operator at the Reduce-side
> -----------------------------------------------------------------------------------------------------
>
> Key: HIVE-4877
> URL: https://issues.apache.org/jira/browse/HIVE-4877
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.12.0
> Reporter: Yin Huai
> Assignee: Yin Huai
> Attachments: HIVE-4877.patch, HIVE-4877.patch
>
>
> In ExecReducer, we can see ...
> {code}
> row.clear();
> row.add(keyObject);
> row.add(valueObject[tag.get()]);
> // The tag is not used any more, we should remove it.
> row.add(tag);
> {\code}
> I have seen this for a long time. Actually, we are using
> {code}
> reducer.process(row, tag.get());
> {\code}
> to pass the tag.
> If we do not need to add the tag to a row, we should remove it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
